-
Notifications
You must be signed in to change notification settings - Fork 2
fix: branding text #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe update modifies the initialization of the Changes
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new isBrandingEnabled
flag to the WebViewData
payload, allowing in-app survey branding to be toggled via the environment response (defaulting to true
).
- Introduces
isBrandingEnabled
in thedata
dictionary, driven byenvironmentResponse.data.data.project.inAppSurveyBranding
- Applies a default
true
fallback when the backend value is missing
Comments suppressed due to low confidence (1)
Sources/FormbricksSDK/WebView/FormbricksViewModel.swift:101
- Add unit tests for
WebViewData
to verify thatisBrandingEnabled
is correctly set wheninAppSurveyBranding
is true, false, or undefined.
data["isBrandingEnabled"] = environmentResponse.data.data.project.inAppSurveyBranding ?? true
|
Fixes https://github.com/formbricks/internal/issues/651
This pull request introduces a minor enhancement to the
WebViewData
class inFormbricksViewModel.swift
. The change adds a new key-value pair to thedata
dictionary to support branding configuration for in-app surveys.Enhancement to branding configuration:
isBrandingEnabled
to thedata
dictionary, which determines whether in-app survey branding is enabled based on theenvironmentResponse
data. Defaults totrue
if the value is not provided. (Sources/FormbricksSDK/WebView/FormbricksViewModel.swift
, Sources/FormbricksSDK/WebView/FormbricksViewModel.swiftR101)Summary by CodeRabbit
Summary by CodeRabbit