Group 1: Minor refactoring #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,19 @@ | |||
| package flight.reservation.plane; | |||
|
|
|||
| public class Vehicle { | |||
There was a problem hiding this comment.
Vehicles can also be on wheels. Aircraft would be a better name.
SandroWeber
reviewed
Nov 23, 2021
|
|
||
| public class Passenger extends Person { |
There was a problem hiding this comment.
introducing Person as a class, the Passenger class seems a bit "empty". Person class itself also seems empty, is the idea to distinguish passengers and crew? Maybe just have either Person or Customer with all the info and a ScheduledFlight could then have a List<Customer> passengers?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors flight classes and introduce person class