Group 2: Aircraft Abstraction and Duplicate Code Removal. #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 23, 2021 10:50
…r and crew capacity. WIP: Tests still broken.
PtrBld
changed the title
| orders.add(order); | ||
| return order; | ||
| } | ||
|
|
||
| private boolean isOrderValid(List<String> passengerNames, List<ScheduledFlight> flights) { |
There was a problem hiding this comment.
Good decision to remove logic that belongs to a specific order
| } | ||
| public abstract class Helicopter implements IAircraft { | ||
| @Override | ||
| public int getCrewCapacity() { return 2; } |
There was a problem hiding this comment.
I think it is not ideal to enforce each helicopter with 2 crew member (although this setup allows it)
| @@ -12,9 +10,9 @@ | |||
| private int number; | |||
| private Airport departure; | |||
| private Airport arrival; | |||
| protected Object aircraft; | |||
| protected IAircraft aircraft; | |||
There was a problem hiding this comment.
Good decision to remove object casting with base class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.