Add user filter on findDelegation (rebased) #1999
Merged
+29
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed extra validations no longer needed after having a dynamic ldap filter
|
We analyzed the effects removing the "(!(UserAccountControl:1.2.840.113556.1.4.803:=8192))" filter (present in the original PR). This is indeed the behavior that we want (DCs should always be returned, because despite their delegations being unconstrained by default they CAN be changed). Some further checks on returned records were no longer needed so they were removed (related to the -disabled flag, which now changes the resulting LDAP query, so the query itself filters what we need) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added a missing filter from master (only non domain controllers allowed) in order to keep the same behavior as before.