feat(DNS): Add static cleanup funcs#100
Open
LaurenceJJones wants to merge 2 commits intofosrl:mainfrom
Open
Conversation
When the tunnel is forced close an integration may want to manually call cleanup function to fix stale issues without having the knowledge of which configuration to cleanup
To aid CLI in cleaning up configuration we expose static functions that know how to handle each provider and platform linked to fosrl/cli#38
Member
|
@LaurenceJJones we still want to merge this right? |
Member
Author
|
Yeah we can merge, then test functionality on the CLI. These are just static function that no client is using yet. edit: we'll need to do a release or something to bump deps |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Contribution License Agreement
By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.
Description
Add static cleanup functions inside olm so other implementations can invoke these to cleanup configuration of olm without explicitly needing to know which configuration olm creates.
How to test?
Currently this is purely just a SDK improvement to which the CLI will need to implement these as either prerun hooks to
upanddownor we add apangolin cleanupfunction so it explicit.