-
Notifications
You must be signed in to change notification settings - Fork 133
Update mobile view #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update mobile view #143
Conversation
@mariobehling Please review and merge! Thanks :) |
@pranavkarthik10 pls have a look at the |
@Dishebh Thank you for letting me know! I have fixed it and simplified the code massively by converting the schedule roster section to an image. It still preserves quality in different devices. |
@mariobehling Please review this! Thank you. |
@mariobehling Please review and merge when you get a chance. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually we would like to have the schedule as html not as an image.
@mariobehling May I know why, otherwise the schedule roster section is the only reason why the mobile view does not look good. There are other ways to make it responsive but it would not look as good as the desktop version. |
Changes done in this Pull Request
Description / Changes
I updated the view using the overflow-x attribute for the body to hidden which allowed all overflow to be modified and changed to only fit the view.
Screenshots if any:
Before:
After: