Skip to content

Update mobile view #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

pranavkarthik10
Copy link

  • Included a Preview link and screenshot showing after and before the changes.
  • Included a description of the change below.
  • Squashed the commits.

Changes done in this Pull Request

Description / Changes

I updated the view using the overflow-x attribute for the body to hidden which allowed all overflow to be modified and changed to only fit the view.

Screenshots if any:

Before:

Screen Shot 2019-12-29 at 3 43 30 PM

After:

Screen Shot 2019-12-29 at 3 19 15 PM


@pranavkarthik10
Copy link
Author

@mariobehling Please review and merge! Thanks :)

@Dishebh
Copy link
Member

Dishebh commented Jan 1, 2020

@pranavkarthik10 pls have a look at the Schedule Roster section, hope it doesn't get affected / cut due to this. Thanks.

@pranavkarthik10
Copy link
Author

@Dishebh Thank you for letting me know! I have fixed it and simplified the code massively by converting the schedule roster section to an image. It still preserves quality in different devices.
Screen Shot 2020-01-01 at 8 44 36 PM

@pranavkarthik10
Copy link
Author

@mariobehling Please review this! Thank you.

@pranavkarthik10
Copy link
Author

@mariobehling Please review and merge when you get a chance. Thanks!

Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually we would like to have the schedule as html not as an image.

@pranavkarthik10
Copy link
Author

@mariobehling May I know why, otherwise the schedule roster section is the only reason why the mobile view does not look good. There are other ways to make it responsive but it would not look as good as the desktop version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix mobile Display of start page
4 participants