Skip to content

Make Exhibitors unique to event #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Sak1012
Copy link
Member

@Sak1012 Sak1012 commented May 16, 2025

This PR has fixes

  • The Exhibitor List View properly fetch exhibitors unique to the event by adding get_queryset()
  • Fixes bugs:
    • Add missing import for messages from django.contrib to properly show success messages
    • Add missing import for generate_booth_id from models

Summary by Sourcery

Scope exhibitor list view to the event, restore missing imports, and refine settings persistence and messaging

Bug Fixes:

  • Add missing import for generate_booth_id
  • Correct messages.success call to use the view’s request object

Enhancements:

  • Limit exhibitor listings to the current event by overriding get_queryset
  • Capture the created flag when retrieving or creating exhibitor settings

Copy link
Contributor

sourcery-ai bot commented May 16, 2025

Reviewer's Guide

This PR enhances the ExhibitorListView to only fetch exhibitors for the current event and resolves import and minor logic bugs in the SettingsView post handler.

File-Level Changes

Change Details Files
Filter exhibitors by current event
  • Add get_queryset override filtering by self.request.event
exhibitors/views.py
Add missing imports
  • Import generate_booth_id from models
  • Import messages from django.contrib
exhibitors/views.py
Improve SettingsView post handling
  • Capture ‘created’ flag from get_or_create instead of using a throwaway underscore
  • Use self.request in messages.success to ensure correct request context
exhibitors/views.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@Sak1012 Sak1012 requested a review from mariobehling May 16, 2025 15:24
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Sak1012 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant