Upgrade open telemetry #403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evaline-ju
reviewed
Jun 2, 2025
mdevino
force-pushed
the
upgrade_open_telemetry
branch
from
8cfcd33 to
e826c1a
Compare
|
@evaline-ju Thanks. I've just pushed a rebase. Just not sure if merging this prior to #391 and #393 will cause any conflicts for them as those seem more complex. |
Signed-off-by: Mateus Devino <[email protected]>
Signed-off-by: Mateus Devino <[email protected]>
mdevino
force-pushed
the
upgrade_open_telemetry
branch
from
e826c1a to
8737a6b
Compare
evaline-ju
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #354.
Based myself on migration guides to 0.28 and 0.29.
Changes summary:
TracerProvidertoSdkTracerProvider.Resourcecreation (using builder pattern).runtime::Tokioas a parameter.shutdown()now must be called from the providers, not fromglobal.BuilderErrorandShutdownError.