Skip to content

Upgrade tonic to 0.13.1 #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 4, 2025
Merged

Upgrade tonic to 0.13.1 #407

merged 5 commits into from
Jun 4, 2025

Conversation

mdevino
Copy link
Collaborator

@mdevino mdevino commented Jun 2, 2025 •
edited
Loading

Closes #395.

Diff of changes required to upgrade Tonic.

@mdevino mdevino mentioned this pull request Jun 3, 2025
Merged
mdevino added 3 commits June 4, 2025 13:55
@mdevino
wip: upgrade tonic
7924bd3 
Signed-off-by: Mateus Devino <[email protected]>
@mdevino
Update ginepro
8d1044c 
Signed-off-by: Mateus Devino <[email protected]>
@mdevino
Fix ginepro revision
2289c7d 
Signed-off-by: Mateus Devino <[email protected]>
@mdevino mdevino changed the title [WIP] Upgrade tonic to 0.13.1 Upgrade tonic to 0.13.1 Jun 4, 2025
@mdevino
Copy link
Collaborator Author

mdevino commented Jun 4, 2025

Closes #395.

@mdevino mdevino marked this pull request as ready for review June 4, 2025 17:03
@mdevino
Remove ginepro version
ec8b250 
Signed-off-by: Mateus Devino <[email protected]>
@declark1
Copy link
Collaborator

declark1 commented Jun 4, 2025 •
edited
Loading

What's the difference between your ginepro fork and Gaurav's? I assumed just the tonic version but it looks like there are other commit diffs, so I'm not sure. We should probably document somewhere why we are forking it and what we are changing, for future reference.

@mdevino
Copy link
Collaborator Author

mdevino commented Jun 4, 2025

What's the difference between your ginepro fork and Gaurav's? I assumed just the tonic version but it looks like there are other commit diffs, so I'm not sure. We should probably document somewhere why we are forking it and what we are changing, for future reference.

@declark1 I'd forgotten to update it to point to Gaurav's fork. Just did it. The changes in ginepro are Gaurav's changes + the changes needed to upgrade tonic to 0.13.

@mdevino
Update ginepro's fork
396e8cb 
Signed-off-by: Mateus Devino <[email protected]>
@mdevino
Copy link
Collaborator Author

mdevino commented Jun 4, 2025

Diff of changes required to upgrade Tonic.

declark1
declark1 approved these changes Jun 4, 2025
View reviewed changes
Copy link
Collaborator

@declark1 declark1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@declark1 declark1 merged commit 19d9452 into foundation-model-stack:main Jun 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@declark1 declark1 declark1 approved these changes

@gkumbhat gkumbhat Awaiting requested review from gkumbhat gkumbhat is a code owner

@evaline-ju evaline-ju Awaiting requested review from evaline-ju evaline-ju is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update tonic to 0.13.1 and opentelemetry to 0.29.*
2 participants
@mdevino @declark1