Skip to content

fix: OpenAiClient streaming error handling #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2025

Conversation

declark1
Copy link
Collaborator

@declark1 declark1 commented Jul 3, 2025

This PR fixes an issue where OpenAI/vLLM errors sent over a stream were not being deserialized and passed through properly.

Example: previously, the below error message was being returned as a generic internal server error.

event: error
data: {"code":400,"details":"Requested sample logprobs of 21, which is greater than max allowed: 20"}

data: [DONE]

Integration test error cases will be added as part of #417.

@declark1 declark1 marked this pull request as ready for review July 3, 2025 17:05
Copy link
Collaborator

@mdevino mdevino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for figuring this one out!

@mdevino mdevino merged commit 6408740 into foundation-model-stack:main Jul 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants