Rename chat_completions config to openai
#438
Open
+47
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mateus Devino <[email protected]>
1 task
This was referenced Jul 4, 2025
gkumbhat
reviewed
Jul 5, 2025
| pub chat_completions: Option<OpenAiConfig>, | ||
| /// Completions service and associated configuration, can be omitted if configuring for chat generation is not wanted | ||
| pub completions: Option<OpenAiConfig>, | ||
| pub openai: Option<OpenAiConfig>, |
There was a problem hiding this comment.
nice, even this one is lining up well with this name
| @@ -229,7 +227,7 @@ impl OrchestratorConfig { | |||
| })?; | |||
| if config_yaml.contains("chat_generation") { | |||
| warn!( | |||
| "`chat_generation` is deprecated and will be removed in 1.0. Rename it to `chat_completions`." | |||
| "`chat_generation` is deprecated and will be removed in 1.0. Rename it to `openai`." | |||
There was a problem hiding this comment.
for precaution's sake. Lets also mention chat_completion being deprecated as well.
| @@ -124,12 +124,11 @@ async fn no_detectors() -> Result<(), anyhow::Error> { | |||
| }); | |||
|
|
|||
| // Start orchestrator server and its dependencies | |||
| let mut mock_chat_completions_server = | |||
| MockServer::new("chat_completions").with_mocks(chat_mocks); | |||
| let mut mock_openai_server = MockServer::new("chat_completions").with_mocks(chat_mocks); | |||
There was a problem hiding this comment.
what to call the name of the MockServer as chat_completions still instead of openai ?
There was a problem hiding this comment.
Because these are tests for chat completions. This name is really used for anything, but I think leaving it as is makes things* clearer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the upcoming work to support Open AI's completions endpoint, we should rename the orchestrator config file entry to
openai, as it will be used for other endpoints rather than just chat completions.