data pre-processor: add to_json flag to jinja handler#575
Open
ChanderG wants to merge 3 commits intofoundation-model-stack:mainfrom
Open
data pre-processor: add to_json flag to jinja handler#575ChanderG wants to merge 3 commits intofoundation-model-stack:mainfrom
ChanderG wants to merge 3 commits intofoundation-model-stack:mainfrom
Conversation
add a new flag to cast the output of the jinja handler to json
|
Thanks for making a pull request! 😃 |
dushyantbehl
requested changes
Jun 26, 2025
Collaborator
dushyantbehl
left a comment
There was a problem hiding this comment.
@ChanderG as discussed internally can we convert this to a separate data handler which can take any column(s) and then convert them to base format?
Also have you had any thought on how the final element should look like? do we want columns for all keys in the json or whole json should be under a single column...
It would be good if we can create a generic piece here which could fit many potential upcoming preference style data engagements.
Signed-off-by: ChanderG <mail@chandergovind.org>
This reverts commit 71c5448.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add a new flag to cast the output of the jinja handler to json