feat: upgrade to transformers v5#659
Open
yash4242 wants to merge 18 commits intofoundation-model-stack:mainfrom
Open
feat: upgrade to transformers v5#659yash4242 wants to merge 18 commits intofoundation-model-stack:mainfrom
yash4242 wants to merge 18 commits intofoundation-model-stack:mainfrom
Conversation
|
Thanks for making a pull request! 😃 |
…xtToText Signed-off-by: Yash Mehan <yashmehan@gmail.com>
…_tokens_seen Signed-off-by: Yash Mehan <yashmehan@gmail.com>
…d llama tokenizer Signed-off-by: Yash Mehan <yashmehan@gmail.com>
Signed-off-by: Yash Mehan <yashmehan@gmail.com>
Signed-off-by: Yash Mehan <yashmehan@gmail.com>
Signed-off-by: Yash Mehan <yashmehan@gmail.com>
…k case Signed-off-by: Yash Mehan <yashmehan@gmail.com>
Signed-off-by: Yash Mehan <yashmehan@gmail.com>
…ay, adding justification for what was renamed Signed-off-by: Yash Mehan <yashmehan@gmail.com>
Signed-off-by: Yash Mehan <yashmehan@gmail.com>
Signed-off-by: Yash Mehan <yashmehan@gmail.com>
Signed-off-by: Yash Mehan <71321431+yash4242@users.noreply.github.com>
dushyantbehl
requested changes
Feb 26, 2026
Collaborator
dushyantbehl
left a comment
There was a problem hiding this comment.
Delete commented code...retain comments only in code files and not in test files.
fix the pyproject file as per comments.
Signed-off-by: Yash Mehan <yashmehan@gmail.com>
Signed-off-by: Yash Mehan <yashmehan@gmail.com>
Signed-off-by: Yash Mehan <yashmehan@gmail.com>
Collaborator
dushyantbehl
left a comment
There was a problem hiding this comment.
Good progress @yash4242
minor changes requested along with updates to the dockerfile to match the incoming changes.
Signed-off-by: Yash Mehan <yashmehan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Making fms-hf-tuning transformers v5 compatible
Related issue number
NA
How to verify the PR
run tests. As of now, some tests fail, most of which are due to a tensor size mismatch. This error comes inside the trainer.train() code
Was the PR tested
Yes.
Tests status as above. I tested out with 9 pytests as follows: