Document vm.mockCalls
#1325
Merged
Document vm.mockCalls
#1325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Evalir
reviewed
Oct 7, 2024
| // Calldata can either be strict or a partial match, e.g. if you only | ||
| // pass a Solidity selector to the expected calldata, then the entire Solidity | ||
| // function will be mocked. | ||
| function mockCalls(address, bytes calldata, bytes[] calldata) external; |
Member
There was a problem hiding this comment.
the version with uint256 msgValue should also be added, no?
Contributor
Author
There was a problem hiding this comment.
I was not sure, since the mockCall with msgValue is not included. By I can include it if you think it should be documented. In that case I should probably add it for mockCall as well?
Contributor
Author
There was a problem hiding this comment.
Added both mockCall and mockCalls with msg.value, lmk if is ok.
| > will receive the last `retdata` element in response. `clearMockedCalls` can be | ||
| > called to clear the mock | ||
| ### Examples |
Member
There was a problem hiding this comment.
We should also have an example that uses the version with uint256 msgValue
Contributor
Author
There was a problem hiding this comment.
I will add and update you
Contributor
Author
There was a problem hiding this comment.
Added an example with msg.value
Evalir
approved these changes
Oct 11, 2024
Member
|
deferring to @mattsse / @DaniPopes for merge. |
mattsse
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for
vm.mockCalls, see foundry-rs/foundry#9024.