Skip to content

Fix: Remove Counter.s.sol to resolve forge build error #1331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2024
Merged

Fix: Remove Counter.s.sol to resolve forge build error #1331

merged 1 commit into from
Oct 12, 2024

Conversation

@TomasCImach
Copy link
Contributor

@TomasCImach TomasCImach commented Oct 11, 2024

This PR updates the setup instructions to remove the Counter.s.sol script file along with other Counter-related files. This change resolves a forge build error caused by the presence of the unused Counter script.

Changes made:

  • Updated the shell command to remove script/Counter.s.sol
  • This ensures a clean project setup for the NFT tutorial

DaniPopes
DaniPopes approved these changes Oct 12, 2024
View reviewed changes
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DaniPopes DaniPopes merged commit 786f594 into foundry-rs:master Oct 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@Evalir Evalir Awaiting requested review from Evalir

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TomasCImach @DaniPopes