Skip to content

feat: vm.getWallets()#620

Merged
yash-atreya merged 4 commits intomasterfrom
yash/script-wallets
Oct 15, 2024
Merged

feat: vm.getWallets()#620
yash-atreya merged 4 commits intomasterfrom
yash/script-wallets

Conversation

@yash-atreya
Copy link
Contributor

@yash-atreya yash-atreya commented Oct 8, 2024

Companion PR for foundry-rs/foundry#9052

Adds the cheatcode function getWallets() external returns (address[] memory wallets)

@yash-atreya yash-atreya marked this pull request as ready for review October 9, 2024 05:47
@yash-atreya yash-atreya requested a review from DaniPopes October 10, 2024 13:28
@zerosnacks
Copy link
Member

Hey Yash, when adding cheatcodes make sure to run scripts/vm.py as documented here https://github.com/foundry-rs/forge-std/blob/master/CONTRIBUTING.md#adding-cheatcodes

It will automate the adding of the cheatcode in Vm.sol

@yash-atreya
Copy link
Contributor Author

yash-atreya commented Oct 14, 2024

Renamed to vm.getWallets() as per foundry-rs/foundry#9106

@yash-atreya yash-atreya changed the title feat: vm.getScriptWallets() feat: vm.getWallets() Oct 14, 2024
@yash-atreya yash-atreya marked this pull request as draft October 14, 2024 09:03
@yash-atreya
Copy link
Contributor Author

Merge after foundry-rs/foundry#9106

@yash-atreya yash-atreya marked this pull request as ready for review October 14, 2024 14:04
@yash-atreya yash-atreya merged commit 1de6eec into master Oct 15, 2024
@DaniPopes DaniPopes deleted the yash/script-wallets branch October 24, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants