feat: add Sourcify trace identifier #11917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
requested review from
0xrusowsky,
grandizzy,
mattsse,
onbjerg,
yash-atreya and
zerosnacks
as code owners
onbjerg
approved these changes
Oct 20, 2025
Contributor
onbjerg
left a comment
onbjerg
left a comment
There was a problem hiding this comment.
lgtm, makes sense to me that we make this abstraction generic over an external fetcher and the impls of those look fine to me too
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
0xrusowsky
approved these changes
Oct 21, 2025
silvekkk
added a commit
to silvekkk/foundry
that referenced
this pull request
Oct 21, 2025
Add contract name and address to error messages when compiling contracts from Etherscan/Sourcify fails, making it easier to identify which specific contract caused the compilation failure. Applies the same improvement as PR foundry-rs#12152 to the refactored external.rs file (after the Sourcify integration in foundry-rs#11917).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 21, 2025
…12152) * feat(traces): add contract context to compilation errors Add contract name and address to error messages when compiling contracts from Etherscan/Sourcify fails, making it easier to identify which specific contract caused the compilation failure. Applies the same improvement as PR #12152 to the refactored external.rs file (after the Sourcify integration in #11917). * chore: avoid redundant work and allocations --------- Co-authored-by: 0xrusowsky <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite crates/evm/traces/src/identifier/etherscan.rs to support multiple endpoints. Sourcify is enabled by default (if not offline).
Supersedes #11817.