Skip to content

fix: correct bytecode placeholder replacement length #12656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

fix: correct bytecode placeholder replacement length #12656

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/common/src/utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,8 @@ pub fn strip_bytecode_placeholders(bytecode: &BytecodeObject) -> Option<Bytes> {
match &bytecode {
BytecodeObject::Bytecode(bytes) => Some(bytes.clone()),
BytecodeObject::Unlinked(s) => {
// Replace all __$xxx$__ placeholders with 32 zero bytes
let s = (*BYTECODE_PLACEHOLDER_RE).replace_all(s, "00".repeat(40));
// Replace all __$xxx$__ placeholders with 20 zero bytes (40 hex chars)
let s = (*BYTECODE_PLACEHOLDER_RE).replace_all(s, "00".repeat(20));
let bytes = hex::decode(s.as_bytes());
Some(bytes.ok()?.into())
}
Expand Down
Loading