fix(chisel): add known_contracts support for trace decoding #13051
+85
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
decode_tracesmethod had a TODO to restoreknown_contractssupport. Without it, chisel only uses external sources for trace decoding, resulting in lower quality traces compared to other Foundry tools. Local contracts written in the REPL cannot be properly identified in traces.Solution
Restored
known_contractssupport by:ContractsByArtifactparameter todecode_tracesSessionSourceand creatingContractsByArtifactwith_known_contracts()andwith_local()to improve decoder and identifierThis matches the pattern used in
castandforgefor consistency.PR Checklist