feat(cheatcodes): support both 4844/7594 formats in attachBlob
#13054
+14
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mablr
commented
Jan 11, 2026
Comment on lines
+231
to
+236
| let sidecar_variant = if ccx.ecx.cfg.spec < SpecId::OSAKA { | ||
| sidecar.build_4844().map_err(|e| format!("{e}"))?.into() | ||
| } else { | ||
| sidecar.build_7594().map_err(|e| format!("{e}"))?.into() | ||
| }; | ||
| ccx.state.active_blob_sidecar = Some(sidecar_variant); |
Contributor
Author
There was a problem hiding this comment.
I propose to select implicitly the blob format based on the spec.
Is there a real use-case for explicit blob format selection ? i.e. use 4844 one after Osaka ?
Member
There was a problem hiding this comment.
Is there a real use-case for explicit blob format selection ? i.e. use 4844 one after Osaka ?
there is not, this format is deprecated on protocol level after osaka
2 tasks
mablr
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
StackOverflowExcept1on
approved these changes
Jan 11, 2026
mattsse
approved these changes
Jan 11, 2026
Comment on lines
+231
to
+236
| let sidecar_variant = if ccx.ecx.cfg.spec < SpecId::OSAKA { | ||
| sidecar.build_4844().map_err(|e| format!("{e}"))?.into() | ||
| } else { | ||
| sidecar.build_7594().map_err(|e| format!("{e}"))?.into() | ||
| }; | ||
| ccx.state.active_blob_sidecar = Some(sidecar_variant); |
Member
There was a problem hiding this comment.
Is there a real use-case for explicit blob format selection ? i.e. use 4844 one after Osaka ?
there is not, this format is deprecated on protocol level after osaka
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Close #12363
Solution
BlobTransactionSidecarVariantinattachBlobcheatcode support both 4844/7594 formatsPR Checklist