Skip to content

Simplify maybe_predeploy_contract by removing redundant flag #13060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kilavvy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Simplify maybe_predeploy_contract by removing redundant flag #13060

kilavvy wants to merge 1 commit into from

Conversation

@kilavvy
Copy link

@kilavvy kilavvy commented Jan 12, 2026

This PR removes an unnecessary mutable maybe_predeploy variable in crates/verify/src/utils.rs by returning true/false directly from each match branch.

  • No behavior change (pure refactor)
  • Reduces dead/duplicated state and improves readability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@grandizzy grandizzy Awaiting requested review from grandizzy grandizzy is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@0xrusowsky 0xrusowsky Awaiting requested review from 0xrusowsky 0xrusowsky is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

Foundry
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kilavvy