fix(cheatcodes): make vm.fee, vm.txGasPrice, and vm.blobhashes work in isolation mode
#13065
+123
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…work in isolation mode In isolation mode, the transaction environment is zeroed for fee-accounting purposes during synthetic transaction execution. This conflicts with cheatcodes that set these values, as the cheatcodes mutate the environment before it is zeroed. The fix decouples the fee-accounting environment from the contract-visible environment by: 1. Adding `EnvOverrides` to store basefee, gas_price, and blob_hashes overrides 2. Adding `in_isolation_context` flag to `Cheatcodes`, set by `InspectorStack` 3. Intercepting `BASEFEE`, `GASPRICE`, and `BLOBHASH` opcodes in `step_end` to replace stack values with the overrides 4. Updating `vm.fee`, `vm.txGasPrice`, and `vm.blobhashes` to always set overrides, and only modify the actual environment when not in isolation mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In isolation mode, the transaction environment is zeroed for fee-accounting purposes during synthetic transaction execution. This conflicts with cheatcodes that set these values, as the cheatcodes mutate the environment before it is zeroed.
The fix decouples the fee-accounting environment from the contract-visible environment by:
EnvOverridesto store basefee, gas_price, and blob_hashes overridesin_isolation_contextflag toCheatcodes, set byInspectorStackBASEFEE,GASPRICE, andBLOBHASHopcodes instep_endto replace stack values with the overridesvm.fee,vm.txGasPrice, andvm.blobhashesto always set overrides, and only modify the actual environment when not in isolation modeCloses #7277
PR Checklist