fix(cli): avoid panic on invalid remappings env and validate config path#13660
Open
edgarr1986 wants to merge 2 commits intofoundry-rs:masterfrom
Open
fix(cli): avoid panic on invalid remappings env and validate config path#13660edgarr1986 wants to merge 2 commits intofoundry-rs:masterfrom
edgarr1986 wants to merge 2 commits intofoundry-rs:masterfrom
Conversation
edgarr1986
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
onbjerg
requested changes
Mar 9, 2026
Member
onbjerg
left a comment
onbjerg
left a comment
There was a problem hiding this comment.
in the future I would recommend splitting PRs more. for example, the remapping change looks good to me in this PR, but the config path validation does not. had it been split we could merge the remappings fix without blocking on the latter:)
crates/cli/src/opts/build/paths.rs
Outdated
| return Err(format!("config-path `{}` does not exist", path.display())); | ||
| } | ||
| if path.file_name() != Some(OsStr::new(Config::FILE_NAME)) { | ||
| return Err("the config-path must be a path to a foundry.toml file".to_string()); |
Member
There was a problem hiding this comment.
we should not enforce the file name. if you specify --config-path, it's perfectly valid to point to e.g. foundry.dev.toml or foundry.example.toml or whatever else you want
Contributor
Author
There was a problem hiding this comment.
@onbjerg Updated as requested, thanks for your time!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invalid remappings env inputs now produce a warning instead of a panic