feat: patch --browser priority fee#13700
Open
sakulstra wants to merge 8 commits intofoundry-rs:masterfrom
Open
feat: patch --browser priority fee#13700sakulstra wants to merge 8 commits intofoundry-rs:masterfrom
sakulstra wants to merge 8 commits intofoundry-rs:masterfrom
Conversation
sakulstra
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-019cd8d2-538d-755d-9449-01c1c408f5b4
zerosnacks
force-pushed
the
fix/browser-gas
branch
from
0e10c40 to
fc61dec
Compare
zerosnacks
previously approved these changes
Mar 10, 2026
zerosnacks
approved these changes
Mar 10, 2026
zerosnacks
reviewed
Mar 11, 2026
Member
zerosnacks
left a comment
zerosnacks
left a comment
There was a problem hiding this comment.
Would prefer one more review from @onbjerg / @grandizzy as it touches a sensitive code path, fix looks good
zerosnacks
requested changes
Mar 13, 2026
Member
zerosnacks
left a comment
zerosnacks
left a comment
There was a problem hiding this comment.
Hi @sakulstra, given that this change is --browser specific would you mind gating this new behavior behind this?
Contributor
Author
|
@zerosnacks done, but also removed the test as idk how to test the --browser path 😅 |
zerosnacks
requested changes
Mar 17, 2026
Co-authored-by: zerosnacks <95942363+zerosnacks@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When trying to use --browser via rabby on base, txns are failing.
Solution
The issue seems to be that rabby overwrites the priority fee of 1 wei, which then breaks the invariant on maxFeePerGas.
PR Checklist