feat: add gas_snapshot_check flag to config, fix FORGE_SNAPSHOT_CHECK behavior
#9791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…checking for bool value - not just existence
zerosnacks
added
the
T-likely-breaking
zerosnacks
changed the title
gas_snapshot_check flag to config, update FORGE_SNAPSHOT_CHECK to gas_snapshot_check flag to config, fix FORGE_SNAPSHOT_CHECK behavior
zerosnacks
requested review from
DaniPopes,
grandizzy,
klkvr,
mattsse and
yash-atreya
as code owners
grandizzy
reviewed
Jan 30, 2025
zerosnacks
added a commit
to foundry-rs/book
that referenced
this pull request
Jan 30, 2025
zerosnacks
added a commit
to foundry-rs/book
that referenced
this pull request
Jan 30, 2025
* update docs in accordance to foundry-rs/foundry#9791 and foundry-rs/foundry#9645 * nit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes: #9734
Unblocks: #9697 / #9710
Solution
Maintains backwards compatibility of
FORGE_SNAPSHOT_CHECKwith the added restriction of it requiring a boolean value (FORGE_SNAPSHOT_CHECK=true) in accordance to the other configuration items.Evaluates in the following order:
Default is false
FORGE_SNAPSHOT_CHECK=trueis setgas_snapshot_check=trueis set in the config--gas-snapshot-check=<bool>which takes preference over all, bothtrueandfalseMarked as minor breaking due to
FORGE_SNAPSHOT_CHECKnow explicitly checking for truthiness, not just existence