Skip to content

Fix VBK exception types #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025
Merged

Fix VBK exception types #15

merged 1 commit into from
Apr 4, 2025

Conversation

Schamper
Copy link
Member

@Schamper Schamper commented Apr 3, 2025

They weren't all properly defined and subclassed.

Copy link

codecov bot commented Apr 3, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.81%. Comparing base (91e1ee7) to head (c69a632).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dissect/archive/vbk.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
- Coverage   68.92%   68.81%   -0.11%     
==========================================
  Files           9        9              
  Lines        1197     1193       -4     
==========================================
- Hits          825      821       -4     
  Misses        372      372              
Flag Coverage Δ
unittests 68.81% <50.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Schamper Schamper merged commit e6e8407 into main Apr 4, 2025
21 of 23 checks passed
@Schamper Schamper deleted the fix-vbk-exceptions branch April 4, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants