Skip to content

Conversation

@Miauwkeru
Copy link
Contributor

@Miauwkeru Miauwkeru commented Jan 21, 2026

No description provided.

Add functionality to search for the specific index tables
This is for AsdfSnapshot that includes the offset inside the block
So that the table is required for return the table data and cleanup of
itself
@Miauwkeru Miauwkeru force-pushed the asdf-intermediate-data-flushing branch from 2ba0059 to 08f4761 Compare January 28, 2026 10:41
@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

❌ Patch coverage is 94.02985% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.89%. Comparing base (72b05e7) to head (08f4761).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dissect/evidence/asdf/asdf.py 93.98% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
+ Coverage   71.44%   72.89%   +1.45%     
==========================================
  Files          23       23              
  Lines        1387     1476      +89     
==========================================
+ Hits          991     1076      +85     
- Misses        396      400       +4     
Flag Coverage Δ
unittests 72.89% <94.02%> (+1.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Miauwkeru
Copy link
Contributor Author

Intermediate flushing is added, and added logic to find the table entries and combine it with _table_fit.
The table_index struct contains information about the previous table, and the indexes that where flushed to the current table. This is to have a faster lookup if we are only interested in one specific index.

I can think of one limitation tho. Once the table flushed all its contents to disk, there is the issue that duplicate data can be written. Maybe it is a good idea to have an additional asdf tool to remove this kind of duplication from the file.

@Miauwkeru Miauwkeru marked this pull request as ready for review January 28, 2026 10:46
@Miauwkeru Miauwkeru requested a review from Schamper January 28, 2026 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants