This repository was archived by the owner on Nov 20, 2025. It is now read-only.
fix: all integer serial types should be twos complement#35
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
=======================================
Coverage 74.16% 74.16%
=======================================
Files 5 5
Lines 511 511
=======================================
Hits 379 379
Misses 132 132
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Miauwkeru
reviewed
Jun 12, 2025
Comment on lines
+89
to
+94
| 1: c_sqlite3.int8, | ||
| 2: c_sqlite3.int16, | ||
| 3: c_sqlite3.int24, | ||
| 4: c_sqlite3.int32, | ||
| 5: c_sqlite3.int48, | ||
| 6: c_sqlite3.int64, |
Contributor
There was a problem hiding this comment.
Is it an idea to put the source of the record format here too?
Miauwkeru
approved these changes
Jun 12, 2025
Member
|
Can you capitalize the commit message when merging? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #29
Also fixes some of activitiescache crashes (ValueError: ('year must be in 1..9999', 8921187) when parsing last_modified_on_client)