Skip to content
This repository was archived by the owner on Nov 20, 2025. It is now read-only.

Comments

Improve constraints parsing#37

Merged
Schamper merged 1 commit intofox-it:mainfrom
JSCU-CNI:fix-constraints-parsing
Jul 28, 2025
Merged

Improve constraints parsing#37
Schamper merged 1 commit intofox-it:mainfrom
JSCU-CNI:fix-constraints-parsing

Conversation

@JSCU-CNI
Copy link
Contributor

Fix for parsing Windows.db Search Index files for PR fox-it/dissect.target#1254.

@codecov
Copy link

codecov bot commented Jul 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.35%. Comparing base (ad29eda) to head (716c7cd).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
+ Coverage   74.16%   74.35%   +0.19%     
==========================================
  Files           5        5              
  Lines         511      507       -4     
==========================================
- Hits          379      377       -2     
+ Misses        132      130       -2     
Flag Coverage Δ
unittests 74.35% <100.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Schamper Schamper merged commit 065cb92 into fox-it:main Jul 28, 2025
25 checks passed
@JSCU-CNI JSCU-CNI deleted the fix-constraints-parsing branch July 28, 2025 13:23
Schamper added a commit that referenced this pull request Jul 28, 2025
Schamper added a commit that referenced this pull request Jul 28, 2025
@Schamper
Copy link
Member

tests/plugins/apps/browser/test_firefox.py in dissect.target is failing as a result of this PR, can you investigate and make a new PR?

@JSCU-CNI
Copy link
Contributor Author

See #39 and fox-it/dissect.target#1258.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants