Add generic GZIP Loader #1456
Open
Add generic GZIP Loader #1456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a loader that allows reading gzipped files. It will pack the gzip file into a
VirtualFileSystem, this way we can access the content without the need to decompress. Than we can use this to pass the new Path (which now no longer has the gzip) to all loaders again. This way you can compress any kind of files currently support by dissect without the need to adapt all loaders for it.From a performance perspective this is not the best, it is considerbly slower than processing a de-compressed version. If someone has a better idea than using the VirtualFileSystem which might perform better let me know!
closes #1455