Improve target-shell autocompletion for dirs with spaces #1485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
|
Schamper
requested changes
Jan 8, 2026
Member
Schamper
left a comment
Schamper
left a comment
There was a problem hiding this comment.
Is it possible to extend the existing autocompletion tests with this?
Co-authored-by: Erik Schamper <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to solve a long-standing annoyance with target-shell, the handling of directories with spaces in the shell autocomplete function. We attempt to solve this by escaping spaces with "\ ", as most real shells do too. This seems to work reasonably well.