Skip to content

Conversation

@twiggler
Copy link
Contributor

match_id is a string, not an integer

Closes #1358

@twiggler twiggler requested a review from Miauwkeru January 16, 2026 13:35
@codecov
Copy link

codecov bot commented Jan 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.74%. Comparing base (40cca25) to head (a633d8c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1502   +/-   ##
=======================================
  Coverage   80.74%   80.74%           
=======================================
  Files         394      394           
  Lines       34614    34614           
=======================================
  Hits        27948    27948           
  Misses       6666     6666           
Flag Coverage Δ
unittests 80.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 16, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing activities-cache-invalid-literal (a633d8c) with main (40cca25)

Summary

✅ 11 untouched benchmarks

Copy link
Contributor

@Miauwkeru Miauwkeru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also verified in the SQL schema [MatchId] is indeed a TEXT field.

@twiggler twiggler force-pushed the activities-cache-invalid-literal branch from 6bd7049 to a633d8c Compare January 19, 2026 13:34
@twiggler twiggler merged commit a7cc81c into main Jan 19, 2026
38 of 45 checks passed
@twiggler twiggler deleted the activities-cache-invalid-literal branch January 19, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Activitiescache plugin bug "invalid literal for int() with base 10"

3 participants