Fix crash in linux.environ plugin when environ file is missing
#1504
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR fixes a bug in the
linux.environplugin where attempting to parse the environment of a process would crash if the/proc/<pid>/environfile does not exist (e.g., kernel threads or race conditions during process termination).Changes:
dissect/target/plugins/os/unix/linux/proc.py: Added an explicit.exists()check in_parse_environbefore attempting to read the file. It now gracefully returns/skips instead of raising an exception.tests/conftest.py: Updated thefs_linux_procfixture to simulate a scenario where a process in/proclacks anenvironfile (conditional mapping).tests/.../test_environ.py:4to3(since one process is now correctly skipped due to the missing file).Testing: