feat: Participant management #45
Conversation
| @@ -0,0 +1,7 @@ | |||
| export interface Participant { | |||
There was a problem hiding this comment.
Will move this to shared/src/api in #43
| @Post('/:id/participants') | ||
| public async joinSession( | ||
| @Param('id') id: string | ||
| ): Promise<Participant | undefined> { |
There was a problem hiding this comment.
I'd prefer to have return type as Promise<Participant>
If for some reason we can't provide a 'Participant', we should throw the appropriate HTTP error
| ): Promise<Participant> { | ||
| assert(await this.hasSession(session), 'Unknown session!'); | ||
|
|
||
| assert( |
There was a problem hiding this comment.
I got that the previous check (hasSession) is basically an assert, whether the consumer found a living session,
but this one is rather an error check IMHO.
The consumer (SessionController) can't verify whether the found living session is in good state or not, therefore it's the responsibility of the SessionService.
As a result, it's not a presumption, but a requirement.
There was a problem hiding this comment.
Will call it verify to reflect the above.
|
|
||
| // Save updated session | ||
| session.participants.push(participant); | ||
| await this.sessionDAO.save(session); |
There was a problem hiding this comment.
This is a rather theoretical question, but what happens if the save of the participant is done, but for some reason session save has failed? We got a fractured/inconsistent state.
My point is here, that we don't express the part-whole connection between them, plus we don't have any transaction-like mechanism.
We should talk about this.
| public async join( | ||
| session: Session, | ||
| options?: JoinSessionOptions | ||
| ): Promise<Participant> { |
There was a problem hiding this comment.
IDK whether we can solve it, but this method violates CQS principle.
Maybe an ideal solution from the consumer:
const session = this.sessionService.find(sessionId);
const participant = this.sessionService.createParticipant(participantOptions);
session.join(participant);
this.sessionService.save(session);
Closes #24