fix: Limit rollback ticks (#324)

Closes #323

Author: elementbound

addons/netfox.extras/plugin.cfg

@@ -3,5 +3,5 @@
 name="netfox.extras"
 description="Game-specific utilities for Netfox"
 author="Tamas Galffy"
-version="1.11.0"
+version="1.11.1"
 script="netfox-extras.gd"

addons/netfox.internals/plugin.cfg

@@ -3,5 +3,5 @@
 name="netfox.internals"
 description="Shared internals for netfox addons"
 author="Tamas Galffy"
-version="1.11.0"
+version="1.11.1"
 script="plugin.gd"

addons/netfox.noray/plugin.cfg

@@ -3,5 +3,5 @@
 name="netfox.noray"
 description="Bulletproof your connectivity with noray integration for netfox"
 author="Tamas Galffy"
-version="1.11.0"
+version="1.11.1"
 script="netfox-noray.gd"

addons/netfox/plugin.cfg

@@ -3,5 +3,5 @@
 name="netfox"
 description="Shared internals for netfox addons"
 author="Tamas Galffy"
-version="1.11.0"
+version="1.11.1"
 script="netfox.gd"

addons/netfox/rollback/network-rollback.gd

@@ -1,4 +1,5 @@
 extends Node
+class_name _NetworkRollback
 
 ## Whether rollback is enabled.
 var enabled: bool = ProjectSettings.get_setting("netfox/rollback/enabled", true)
@@ -7,7 +8,9 @@ var enabled: bool = ProjectSettings.get_setting("netfox/rollback/enabled", true)
 ##
 ## The larger the history limit, the further we can roll back into the past, 
 ## thus the more latency we can manage.
-##
+## [br][br]
+## Rollback won't go further than this limit, regardless of inputs received.
+## [br][br]
 ## [i]read-only[/i], you can change this in the project settings
 var history_limit: int:
 	get:
@@ -21,7 +24,7 @@ var history_limit: int:
 ## state of the game, but let's say the state two frames ago ( offset = 2 ).
 ## This can help with hiding latency, by giving more time for an up-to-date
 ## state to arrive before we try to display it.
-##
+## [br][br]
 ## [i]read-only[/i], you can change this in the project settings
 var display_offset: int:
 	get:
@@ -33,7 +36,7 @@ var display_offset: int:
 ##
 ## With UDP - packets may be lost, arrive late or out of order.
 ## To mitigate this, we send the current and previous n ticks of input data.
-##
+## [br][br]
 ## [i]read-only[/i], you can change this in the project settings
 var input_redundancy: int:
 	get:
@@ -78,6 +81,8 @@ var _resim_from: int
 var _is_rollback: bool = false
 var _simulated_nodes: Dictionary = {}
 
+static var _logger: _NetfoxLogger = _NetfoxLogger.for_netfox("NetworkRollback")
+
 ## Submit the resimulation start tick for the current loop.
 ##
 ## This is used to determine the resimulation range during each loop.
@@ -97,7 +102,7 @@ func notify_simulated(node: Node):
 ##
 ## This is used mostly internally by [RollbackSynchronizer]. The idea is to 
 ## submit each affected node while preparing the tick, and then use
-## [code]is_simulated[/code] to run only the nodes that need to be resimulated.
+## [member is_simulated] to run only the nodes that need to be resimulated.
 func is_simulated(node: Node):
 	return _simulated_nodes.has(node)
 
@@ -117,10 +122,10 @@ func is_rollback_aware(what: Object) -> bool:
 ## simulation for the given rollback tick.
 ##
 ## This is used by [RollbackSynchronizer] to resimulate ticks during rollback.
-## While the _rollback_tick method could be called directly as well, this method
-## exists to future-proof the code a bit, so the method name is not repeated all
-## over the place.
-##
+## While the [code]_rollback_tick[/code] method could be called directly as 
+## well, this method exists to future-proof the code a bit, so the method name
+## is not repeated all over the place.
+## [br][br]
 ## [i]Note:[/i] Make sure to check if the target is rollback-aware, because if
 ## it's not, this method will run into an error.
 func process_rollback(target: Object, delta: float, p_tick: int, is_fresh: bool):
@@ -144,7 +149,15 @@ func _rollback():
 
 	# to = Current tick
 	var to = NetworkTime.tick
-	
+
+	# Limit number of rollback ticks
+	if to - from > history_limit:
+		_logger.warning(
+			"Trying to run rollback for ticks %d to %d, past the history limit of %d" %
+			[from, to, history_limit]
+		)
+		from = NetworkTime.tick - history_limit
+
 	# for tick in from .. to:
 	for tick in range(from, to):
 		_tick = tick

addons/netfox/rollback/rollback-synchronizer.gd

@@ -251,6 +251,11 @@ func _submit_input(input: Dictionary, tick: int):
 		for property in sanitized:
 			for i in range(0, sanitized[property].size()):
 				var t = tick - i
+				if t < NetworkTime.tick - NetworkRollback.history_limit:
+					# Input too old
+					_logger.error("Received input for %s, rejecting because older than %s frames" % [t, NetworkRollback.history_limit])
+					continue
+
 				var old_input = _inputs.get(t, {}).get(property)
 				var new_input = sanitized[property][i]