Merge OSD file format V2 updates #422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed missing sync in exploit step 5
Switch to using new png fonts + .osd file format v2 support: - Use PNG font files instead of the old bin format - Only 2 fonts now; one for sd + one for hd, rather than separate pages - But the PNG can have equivalent of 4 pages; so BF 4.5 colour is supported - OSD v2 support; which uses a 4 char string (BTFL/INAV etc) as the FC identifier. Can still handle v1 files too - Font files now optional; it will use the FC variant to load defaults from the msp-osd repo
|
Just saw #421 after opening this - I'll run through that process later on! |
|
That step 5 fix is already in develop. I'd change the base branch for this PR to go against develop and things should be fine. #421 is just a checklist for the new release. Edit: Ah, this PR is just to merge into master. I'll double check the state of the translations and prepare a new release later today. |
Spanish & Italian update
|
Anything I can do to push this along / make your life easier ? Do shout! |
|
@benlumley Thank you - I just deployed it, could you do me a favor and check on prod that everything is working as it is supposed to? |
|
Looks good! |
|
Whoop, whoop - thanks for checking! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comprises the changes to the OSD overlay tool from last week; we'd like to get MSP-OSD v0.12.2 released; which breaks compatibility with the OSD overlay tool that is live currently. So we'd like to get this released.
This also includes a change/fix from j005u; have checked in with him on discord...
"it may or may not help with step 5 stability, but in any case it's harmless. so yeah, include it."
The one issue; I added a new translation string; which we won't have translations for. But we figure this working with a missing translation trumps this not working and not missing translations.