Skip to content

Fix font filename when font variant is missing #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

jesuslg123
Copy link

Fix invalid font name when the font variant is missing on the OSD file.
It was creating a font_.png file name which was invalid.

Fix invalid font name when the font variant is missing on the osd file.
It was creating a font_.png file name which was invalid.
@j005u
Copy link
Contributor

j005u commented Nov 27, 2024

@jesuslg123 can you also bump the version number to 2.3.1 please?
@stylesuxx remind me please, what was the procedure for pushing things to the develop preview hosting? Merge into develop branch? Did it also need a tag?

@stylesuxx
Copy link
Collaborator

@j005u merging it into develop should deploy it on the develop branch.

Creating a news release (I use git flow) will merge develop into master and that should then deploy to prod. So I'd adjust the base branch to develop and merge that. Test on develop and if everything works as expected merge into master.

I can do that today in the evening...

@j005u
Copy link
Contributor

j005u commented Nov 27, 2024

@jesuslg123 so can you please change the PR base branch (in GH UI) to "develop" instead of "master". Then @stylesuxx can deploy it to the testing version of the configurator.

@stylesuxx
Copy link
Collaborator

I can change the base branch too, no worries...

@jesuslg123 jesuslg123 changed the base branch from master to develop November 27, 2024 16:33
@jesuslg123
Copy link
Author

@stylesuxx feel free to resolve the conflict with the version you prefer please I am afk for today

@stylesuxx stylesuxx merged commit 767f296 into fpv-wtf:develop Nov 27, 2024
@j005u
Copy link
Contributor

j005u commented Nov 28, 2024

@stylesuxx while this wasn't the main issue users were having it does also solve an edge case in relation to .osd recordings from audience mode. Confirmed working, let's release it.

@stylesuxx
Copy link
Collaborator

@j005u will do, I'll merge translation updates too. I am not 100% sure if I can make it today though - latest tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants