Adding primary and secondary text colors#41
Open
evanaze wants to merge 1 commit intofranken-ui:masterfrom
Open
Adding primary and secondary text colors#41evanaze wants to merge 1 commit intofranken-ui:masterfrom
evanaze wants to merge 1 commit intofranken-ui:masterfrom
Conversation
evanaze
commented
Dec 1, 2024
| '.uk-text-muted': { | ||
| '@apply text-muted-foreground': {} | ||
| }, | ||
| '.uk-text-primary': { |
Author
There was a problem hiding this comment.
Lines 51-56 are the only changes in this PR.
|
I use the colors for text and links a lot via tailwind (for example a link might be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Franken-UI doesn't match UIKit's functionality with text coloring. It's missing the following classes:
.uk-text-primaryAdd this class to emphasize text with the primary color..uk-text-secondaryAdd this class to emphasize text with the secondary color..uk-text-successAdd this class to indicate success..uk-text-warningAdd this class to indicate a warning.Evidence:
From Franken-UI documentation

From UIKit documentation

Changes in this PR