-
Notifications
You must be signed in to change notification settings - Fork 5
Add an element "PipelinePart" as possible root-element. #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…xplain why I did not see other ways to get the desired result.
And perhaps we need to document which version of the doc corresponds to what version of the framework somewhere. |
| public enum AdditionalRootElement { | ||
| PIPELINE_PART("PipelinePart", "IPipe", "Wrapper element to help create reusable parts of a pipeline"); | ||
|
|
||
| public static final Map<String, AdditionalRootElement> VALUE_BY_TYPE = Arrays.stream(values()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wellicht even aangeven waarom je voor deze oplossing kiest? Misschien iets met performance ofzo?
| public FrankClassRepository(DocTrees docTrees, Set<? extends Element> classElements, Set<String> includeFilters, Set<String> excludeFilters, Set<String> excludeFiltersForSuperclass) { | ||
| this.excludeFiltersForSuperclass = new HashSet<>(excludeFiltersForSuperclass); | ||
|
|
||
| // This populates the map classesByName |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dank je, lekker verstopt idd
|
In Frank!Doc a new root element should be added that acts as a pipeline (only allows validators/wrappers/pipes). In the framework a step 1:
step 2:
step 3:
|
nielsm5
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
…PartTag # Conflicts: # frank-doc-doclet/src/main/java/org/frankframework/frankdoc/FrankDocJsonFactory.java
Zo'n class PipelinePart / ComponentPipe etc zit nog niet in dit PR. Wat ik daarvoor moet doen in de Frank!Doc heb ik nog niet geheel werkend gekregen. Wat nu in dit PR zit is De rest moet komen in een volgend PR. |
Change Frank!Doc XSD generator to allow extra root elements, beginning with PipelinePart.
This will change the Frank!Doc XSD generation in a way that does not make sense for older versions of the Frank!Framework, so before merging this change we should probably increase the version number to 4.3.0-SNAPSHOT and make a proper release of 4.2.0 to use in Frank!Framework 9.3.x and older.