Fix typo's, code analysis, code quality and formatting#465
Fix typo's, code analysis, code quality and formatting#465evandongen merged 12 commits intomasterfrom
Conversation
tnleeuw
left a comment
tnleeuw
left a comment
There was a problem hiding this comment.
It seems we use different settings for import-order. Perhaps best to synchronise them so we do not get rearranged imports on every PR made my a different developer.
Perhaps we can copy those settings from the Frank!Framework project?
| this.roleName = roleName; | ||
| this.elementType = elementType; | ||
| } | ||
| import org.jspecify.annotations.NonNull;public record ConfigChildKey(String roleName, ElementType elementType) implements ElementChild.AbstractKey { |
There was a problem hiding this comment.
Can you please check the formatting of this line? 😳
There was a problem hiding this comment.
Ohh that's a strange one. Fixed
| // We also apply this method on config child collections where the config children | ||
| // can have different owning elements. This applies when the generic element option | ||
| // is being analysed. Therefore we allow multiple config children that are all | ||
| // is being analyzed. Therefore, we allow multiple config children that are all |
There was a problem hiding this comment.
I prefer British English spelling... 😬
There was a problem hiding this comment.
That's a setting in intellij:
Fixed
| b.append(String.format("%s: (abstract)%n", StringUtils.leftPad(label, maxLabelWidth))); | ||
| } else { | ||
| b.append(String.format("%s: %s\n", StringUtils.leftPad(label, maxLabelWidth), e.xmlElements)); | ||
| b.append(String.format("%s: %s%n", StringUtils.leftPad(label, maxLabelWidth), e.xmlElements)); |
There was a problem hiding this comment.
The %n instead of \n caused some issues with some of the tests for me, I remember. Because the %s is platform-dependent and thus caused me some tests to fail on Windows.
That's why I had not yet changed this earlier 😬
There was a problem hiding this comment.
Yes, with the change in the test it works
| private static final String EXPECTED = String.format(" Master: Master%n" | ||
| + " Object: %n" | ||
| + " Other (from sub): %n" | ||
| + "Other (from summary): %n"); |
There was a problem hiding this comment.
You could perhaps write this as a tripple-quoted string?
| trim_trailing_whitespace = false | ||
| indent_style = space | ||
| indent_size = 2 |
There was a problem hiding this comment.
custom xml settings with 2 spaces made a mess of the pom.xml
I used the frank framework formatting |
…unit test instead of concatenated string
…r Java code style
frank-doc-doclet/src/main/java/org/frankframework/frankdoc/model/ConfigChildKey.java
Outdated
Show resolved
Hide resolved
evandongen
changed the title
2 participants
Bug Fixes
Code Quality
LCM