Skip to content

added docker configuration #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 10, 2025
Merged

Conversation

stijnpotters1
Copy link
Contributor

Only secrets and images have to be fixed for deployment

@stijnpotters1 stijnpotters1 requested a review from philipsens June 4, 2025 12:49
@stijnpotters1 stijnpotters1 self-assigned this Jun 4, 2025
@stijnpotters1 stijnpotters1 linked an issue Jun 4, 2025 that may be closed by this pull request
@stijnpotters1 stijnpotters1 marked this pull request as draft June 4, 2025 12:58
Copy link
Member

@philipsens philipsens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@philipsens
Copy link
Member

How can the BackendURL be changed (asking for deployment) in production?

@stijnpotters1
Copy link
Contributor Author

How can the BackendURL be changed (asking for deployment) in production?

I think you can change the string in the environments.ts file to 'https://insights.frankframework.org' for convenience.
And then you can redirect the requests later on deployment using a proxy.

I have already made this an allowed origin in the backend.

@stijnpotters1 stijnpotters1 requested a review from philipsens June 4, 2025 15:03
@philipsens philipsens marked this pull request as ready for review June 10, 2025 09:04
@philipsens philipsens merged commit 3cc9743 into master Jun 10, 2025
@philipsens philipsens deleted the feat/add-docker-configuration branch June 10, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dockerize FF! Insights
2 participants