Skip to content

RS-3602: Allow selecting https stack #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2024
Merged

RS-3602: Allow selecting https stack #122

merged 1 commit into from
Jul 22, 2024

Conversation

jayvdb
Copy link
Member

@jayvdb jayvdb commented Jul 22, 2024

For the Reviewer

In this repo, we try to follow the conventional comments guidebook when providing feedback to PRs. Please follow the guidebook, to make reviewing a smoother experience for you and me!

Related Tasks

https://franklin-ai.atlassian.net/browse/RS-3602

Depends on

What

  • Add features "native-tls" and "rustls-tls" to allow choosing the HTTPS stack - default is "native-tls" (openssl) which is not changed

Why

rosalind is trying to avoid the openssl stack

Concerns

This section is optional, however if you have any concerns or questions regarding aspects of the PR, they can be included here. Including the concerns in this section ensures that they can be discussed as a part of the PR review.

Notes

This section is also optional and should include anything else that you would like to discuss in the PR review that is not captured elsewhere.

Copy link
Collaborator

@timleslie timleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jayvdb jayvdb merged commit 6012d57 into main Jul 22, 2024
12 checks passed
@jayvdb jayvdb deleted the RS-3602 branch July 22, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants