Skip to content

Commit

Permalink
fix: easy-install.py build command arg for image
Browse files Browse the repository at this point in the history
  • Loading branch information
revant committed Oct 27, 2024
1 parent 1f3f68c commit 18426db
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/easy-install.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ jobs:

- name: Perform production easy install
run: |
python3 ${GITHUB_WORKSPACE}/easy-install.py build
python3 ${GITHUB_WORKSPACE}/easy-install.py -p -n actions_test --email [email protected] --image custom-apps:latest
python3 ${GITHUB_WORKSPACE}/easy-install.py build --image erpnext:version-15
python3 ${GITHUB_WORKSPACE}/easy-install.py -p -n actions_test --email [email protected] --image erpnext:version-15
docker compose -p actions_test exec backend bench version --format json
docker compose -p actions_test exec backend bench --site site1.localhost list-apps --format json
result=$(curl -H "Host: site1.localhost" -sk https://127.0.0.1/api/method/ping | jq -r ."message")
Expand Down
4 changes: 2 additions & 2 deletions easy-install.py
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ def add_build_parser(argparser: argparse.ArgumentParser):
)
build.add_argument(
"-i",
"--image-name",
"--image",
help="Full Image Name, default: custom-apps:latest",
default="custom-apps:latest",
)
Expand Down Expand Up @@ -464,7 +464,7 @@ def build_image(
frappe_path=args.frappe_path,
frappe_branch=args.frappe_branch,
apps_json_path=args.apps_json,
image_name=args.image_name,
image_name=args.image,
containerfile_path=args.containerfile,
python_version=args.python_version,
node_version=args.node_version,
Expand Down

0 comments on commit 18426db

Please sign in to comment.