-
Notifications
You must be signed in to change notification settings - Fork 245
feat: Announcement page to display announcements from newsletters on student portal #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Hi Mania This is seems like a useful feature. Can you use FrappeUI's list view instead of custom cards? In the dialog, "Close" should be just the close icon that will appear by default in FrappeUI's dialog. |
Sure, refactoring. |
Let's remove the calendar emoji and use a formatted date (like 3 hours ago etc.) |
Also, your commit message formats are not consistent: ":", "-", etc. as separator. We stick to conventional commits. Please reformat those using rebase. |
Also, can you fix the dialog UI and update screenshots in PR description? |
7d8e27f
to
56ed63f
Compare
Seen, done |
User creates new newsletter from the Newsletter doctype. Then publish the announcement

Then on the students, click on the Announcement button on sidebar, it will display all announcements

Then you can click on each announcement to see the message which will appear like a dialog box
