Skip to content

feat: Announcement page to display announcements from newsletters on student portal #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

maniamartial
Copy link

User creates new newsletter from the Newsletter doctype. Then publish the announcement
image

Then on the students, click on the Announcement button on sidebar, it will display all announcements
image

Then you can click on each announcement to see the message which will appear like a dialog box
image

@NagariaHussain
Copy link
Contributor

Hi Mania

This is seems like a useful feature. Can you use FrappeUI's list view instead of custom cards?

In the dialog, "Close" should be just the close icon that will appear by default in FrappeUI's dialog.

@NagariaHussain NagariaHussain self-requested a review April 22, 2025 08:18
@maniamartial
Copy link
Author

Hi Mania

This is seems like a useful feature. Can you use FrappeUI's list view instead of custom cards?

In the dialog, "Close" should be just the close icon that will appear by default in FrappeUI's dialog.

Sure, refactoring.

@NagariaHussain NagariaHussain changed the title feat - Announcement page to display announcements from newsletters on student portal feat: Announcement page to display announcements from newsletters on student portal Apr 22, 2025
@maniamartial
Copy link
Author

maniamartial commented Apr 22, 2025

Refactored to use frappe ui(List view), and here is the current display.
Clicking the subject will display the dialogue box which contain more information.
Screenshot 2025-04-22 at 12 34 16

@NagariaHussain
Copy link
Contributor

Let's remove the calendar emoji and use a formatted date (like 3 hours ago etc.)

@maniamartial
Copy link
Author

Let's remove the calendar emoji and use a formatted date (like 3 hours ago etc.)

Screenshot 2025-04-24 at 16 42 18

@NagariaHussain
Copy link
Contributor

NagariaHussain commented Apr 24, 2025

Also, your commit message formats are not consistent: ":", "-", etc. as separator. We stick to conventional commits.

Please reformat those using rebase.

@NagariaHussain
Copy link
Contributor

Also, can you fix the dialog UI and update screenshots in PR description?

@maniamartial
Copy link
Author

maniamartial commented Apr 24, 2025

Also, can you fix the dialog UI and update screenshots in PR description?

Current dialog box showing Newletter in details.
Screenshot 2025-04-24 at 17 55 08

@maniamartial
Copy link
Author

Also, your commit message formats are not consistent: ":", "-", etc. as separator. We stick to conventional commits.

Please reformat those using rebase.

Seen, done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants