Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: accept apply write off amount on Point of sale and use this to send to sales invoice #40417

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

devdiogenes
Copy link
Contributor

@devdiogenes devdiogenes commented Mar 12, 2024

The objective is allow the POS user to inform how much change was passed to the customer, and add the difference to the write-off amount.

pos_payment.js:
-> A new column hes been added to totals for the write-off amount.
-> In the total change column, if there is change value, it div becames editable, allowing the user to input the actual change value.
-> The write-off amount will be calculed based in the change column that the user edited, using the focus and focusout events.

Animation

pos_invoice_merge_log.py:
-> When mergin a POS Invoice to Sales Invoice, the write_off_amount and base_write_off_amount values are added for consolidation

Media 2

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Mar 12, 2024
@HarryPaulo
Copy link
Contributor

waint for reviewers

Copy link

stale bot commented Apr 10, 2024

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Apr 10, 2024
@devdiogenes
Copy link
Contributor Author

Waiting for review

@stale stale bot removed the inactive label Apr 10, 2024
Copy link

stale bot commented Apr 27, 2024

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Apr 27, 2024
@HarryPaulo
Copy link
Contributor

someone can review this? @rohitwaghchaure?

@stale stale bot removed the inactive label Apr 29, 2024
Copy link

stale bot commented May 15, 2024

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label May 15, 2024
@HarryPaulo
Copy link
Contributor

@ankush can you review this?

@stale stale bot removed the inactive label May 15, 2024
Copy link

stale bot commented May 31, 2024

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label May 31, 2024
@devdiogenes
Copy link
Contributor Author

Hello, can someone review this?

@stale stale bot removed the inactive label May 31, 2024
Copy link

stale bot commented Jun 16, 2024

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Jun 16, 2024
@devdiogenes
Copy link
Contributor Author

Waiting reviewers

@stale stale bot removed the inactive label Jun 17, 2024
Copy link

stale bot commented Jul 3, 2024

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Jul 3, 2024
@devdiogenes
Copy link
Contributor Author

Waiting review

@stale stale bot removed the inactive label Jul 4, 2024
Copy link

stale bot commented Jul 20, 2024

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Jul 20, 2024
@devdiogenes
Copy link
Contributor Author

Waiting review

@stale stale bot removed the inactive label Jul 20, 2024
@devdiogenes
Copy link
Contributor Author

Hello @rohitwaghchaure, @s-aga-r
Could you guys help me checking why didn't my workflow checks run?

Copy link

stale bot commented Sep 8, 2024

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Sep 8, 2024
@devdiogenes
Copy link
Contributor Author

waiting review

@stale stale bot removed inactive labels Sep 10, 2024
@devdiogenes devdiogenes changed the title feat: feat: accept apply write off amount on Point of sale and use this to send to sales invoice feat: accept apply write off amount on Point of sale and use this to send to sales invoice Sep 20, 2024
Copy link

stale bot commented Oct 5, 2024

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Oct 5, 2024
@devdiogenes
Copy link
Contributor Author

Waiting review

@stale stale bot removed the inactive label Oct 5, 2024
@devdiogenes devdiogenes reopened this Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants