Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: override indicator color for "Draft" #43449

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ljain112
Copy link
Contributor

indicator colour was not overridden because has_indicator_for_draft was not set.

Before:
image

After:
image

Frappe Support Issue: https://support.frappe.io/app/hd-ticket/22685

@dj12djdjs
Copy link
Collaborator

shouldn't has_indicator_for_draft be set for any submittable doctype? If so, it seems like this is a framework level issue.

@sagarvora
Copy link
Collaborator

shouldn't has_indicator_for_draft be set for any submittable doctype? If so, it seems like this is a framework level issue.

So this flag is there to specify: "whether I should use get_indicator for Draft status or not"
Code: https://github.com/frappe/frappe/blob/5324431fc013ef5f63102680e18bd934c71daa95/frappe/public/js/frappe/model/indicator.js#L72

Current implementations of get_indicator may not all work correctly for Draft (for example if they have an else block), so changing this design would be a breaking change.

@ljain112 ljain112 marked this pull request as draft October 8, 2024 12:25
Copy link

stale bot commented Oct 28, 2024

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants