fix: add missing fields to field_no_map array #43873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NethminaHiker360
requested review from
deepeshgarg007 and
ruthra-kumar
as code owners
NethminaHiker360
changed the title
NethminaHiker360
changed the title
NethminaHiker360
changed the title
ruthra-kumar
approved these changes
Nov 8, 2024
ruthra-kumar
added
backport version-14-hotfix
ruthra-kumar
force-pushed
the
fix-43865-sales-order
branch
from
ac176a7 to
70f090c
Compare
This was referenced Nov 8, 2024
ruthra-kumar
added a commit
that referenced
this pull request
Nov 8, 2024
…-43873 fix: add missing fields to field_no_map array (backport #43873)
ruthra-kumar
added a commit
that referenced
this pull request
Nov 8, 2024
…-43873 fix: add missing fields to field_no_map array (backport #43873)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
make_purchase_order_for_default_suppliermethod in theSales Order.pyfile, thefield_no_maparray lists fields that should not be copied to the Purchase Order. Currently, these two fields are missing from the array (margin_typeandmargin_rate_or_amount), leading to unintended field copies. Adding them to thefield_no_maparray resolves this issue.closes #43865
backport version-15
backport version-14