Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validation trigger #43926

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

rohitwaghchaure
Copy link
Collaborator

Moved validation from save to submit

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Oct 30, 2024
@rohitwaghchaure rohitwaghchaure added backport version-15-hotfix and removed needs-tests This PR needs automated unit-tests. labels Oct 30, 2024
@rohitwaghchaure rohitwaghchaure force-pushed the fixed-support-24591 branch 3 times, most recently from ccf3a35 to c879c46 Compare October 30, 2024 14:42
@rohitwaghchaure rohitwaghchaure merged commit ba9fb4e into frappe:develop Oct 31, 2024
13 checks passed
mergify bot pushed a commit that referenced this pull request Oct 31, 2024
(cherry picked from commit ba9fb4e)
rohitwaghchaure added a commit that referenced this pull request Nov 2, 2024
fix: validation trigger (#43926)

(cherry picked from commit ba9fb4e)

Co-authored-by: rohitwaghchaure <[email protected]>
frappe-pr-bot pushed a commit that referenced this pull request Nov 6, 2024
# [15.41.0](v15.40.0...v15.41.0) (2024-11-06)

### Bug Fixes

* add precision validation ([b665e4e](b665e4e))
* deleting SO/PO will remove its advance payment ledger entry ([d84a3c4](d84a3c4))
* map reference number while reversing journal ([10d8cc9](10d8cc9))
* **return:** set default return warehouse ([e730b8c](e730b8c))
* SO link on PO and add in missing dashboard references on both ([9f7afda](9f7afda))
* validation trigger (backport [#43926](#43926)) ([#43943](#43943)) ([a689830](a689830))
* valuation rate for sales / purchase return for serial / batch nos (backport [#43925](#43925)) ([#43942](#43942)) ([ce42d84](ce42d84))

### Features

* advance payment ledger doctype ([b343334](b343334))
* remove Payroll Entry from Bank Account dashboard (backport [#43931](#43931)) ([#43933](#43933)) ([4a749ce](4a749ce))

### Performance Improvements

* avoid reposting of entries created after stock reco (backport [#43950](#43950)) ([#43961](#43961)) ([7ad664d](7ad664d))
* too many writes error during reposting (backport [#43978](#43978)) ([#43983](#43983)) ([a38819c](a38819c))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants