Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error when saving POS merge log #43989

Merged
merged 2 commits into from
Nov 6, 2024
Merged

fix: error when saving POS merge log #43989

merged 2 commits into from
Nov 6, 2024
+3 −1

Conversation

sagarvora
Copy link
Collaborator

issue

builtins.AttributeError: 'list' object has no attribute 'pos_invoice'

fix

check the first invoice in the list, instead of the list itself.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Nov 6, 2024
@sagarvora sagarvora enabled auto-merge (squash) November 6, 2024 07:26
@sagarvora sagarvora added backport version-14-hotfix backport to version 14 backport version-15-hotfix and removed needs-tests This PR needs automated unit-tests. labels Nov 6, 2024
@sagarvora sagarvora merged commit c62596b into frappe:develop Nov 6, 2024
13 checks passed
mergify bot pushed a commit that referenced this pull request Nov 6, 2024
@sagarvora @mergify
fix: error when saving POS merge log (#43989)
657bd37 
(cherry picked from commit c62596b)
@mergify mergify bot mentioned this pull request Nov 6, 2024
Merged
mergify bot pushed a commit that referenced this pull request Nov 6, 2024
@sagarvora @mergify
fix: error when saving POS merge log (#43989)
c3e61ae 
(cherry picked from commit c62596b)
@mergify mergify bot mentioned this pull request Nov 6, 2024
Merged
sagarvora added a commit that referenced this pull request Nov 6, 2024
@sagarvora
Merge pull request #43991 from frappe/mergify/bp/version-15-hotfix/pr…
36b22e2 
…-43989

fix: error when saving POS merge log (backport #43989)
sagarvora added a commit that referenced this pull request Nov 6, 2024
@sagarvora
Merge pull request #43990 from frappe/mergify/bp/version-14-hotfix/pr…
876af6d 
…-43989

fix: error when saving POS merge log (backport #43989)
@sagarvora sagarvora deleted the fix-24472 branch November 6, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sagarvora