Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: misc batch enrollment issues #1300

Merged
merged 3 commits into from
Feb 11, 2025
Merged

fix: misc batch enrollment issues #1300

merged 3 commits into from
Feb 11, 2025

Conversation

pateljannat
Copy link
Collaborator

@pateljannat pateljannat commented Feb 11, 2025 •
edited
Loading

  1. Payment reminders were being sent to moderators too. Instead, the batch instructor will now be cc'ed on the email.
  2. If, for some reason, a batch confirmation email is not sent, a Send Confirmation Email button would be seen on top of the document; clicking that button would trigger the email again.
  3. Fixed issues in the Batch Statistics graph.
  4. The quiz timer used to be visible even if the duration was set to 0, fixed that.
  5. Changed the naming series for LMS Payment as used the messy format type.
  6. Deleted Batch Student doctype.
  7. Deleted Payment Reminder Notification.

@cypress Cypress
Copy link

cypress bot commented Feb 11, 2025 •
edited
Loading

lms    Run #1039

Run Properties:  status check passed Passed #1039  •  git commit d52c14a234 ℹ️: Merge b6cfcd797bb828b384ee0f16562c0703d3f8daf6 into 9da1249e5107d843f8c31f9a0a58...
Project lms
Branch Review issues-73
Run status status check passed Passed #1039
Run duration 00m 33s
Commit git commit d52c14a234 ℹ️: Merge b6cfcd797bb828b384ee0f16562c0703d3f8daf6 into 9da1249e5107d843f8c31f9a0a58...
Committer Jannat Patel
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@pateljannat pateljannat marked this pull request as ready for review February 11, 2025 09:32
@pateljannat pateljannat merged commit 879dfac into frappe:develop Feb 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pateljannat